From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH 1 of 3] IOMMU: Add command line param to
	disable sharing of IOMMU and hap tables
Date: Thu, 22 Mar 2012 11:03:00 +0000
Message-ID: <20120322110300.GF37468@ocelot.phlegethon.org>
References: <patchbomb.1332357777@xdev.gridcentric.ca>
	<642c0e6a01c2e30e6043.1332357778@xdev.gridcentric.ca>
	<4F6AFC2D020000780007A1CC@nat28.tlf.novell.com>
	<20120322104435.GC37468@ocelot.phlegethon.org>
	<4F6B1396020000780007A30D@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <4F6B1396020000780007A30D@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: olaf@aepfle.de, keir@xen.org, hongkaixing@huawei.com, andres@gridcentric.ca, xen-devel@lists.xen.org, wei.wang2@amd.com, Andres Lagar-Cavilla <andres@lagarcavilla.org>, adin@gridcentric.ca
List-Id: xen-devel@lists.xenproject.org

At 10:57 +0000 on 22 Mar (1332413830), Jan Beulich wrote:
> >          if ( !parse_bool(s) )
> > -            iommu_enabled = 0;
> > +            iommu_enabled = val;
> 
> ... this one must remain unchanged, and the handling of the "no-"
> prefix should come afterwards.

Meh.  I reserve the right to set 'iommu=no-yes'. :)  
That is to say, I don't think it makes any real difference.

Tim.

> >          else if ( !strcmp(s, "force") || !strcmp(s, "required") )
> > -            force_iommu = 1;
> > +            force_iommu = val;
> >          else if ( !strcmp(s, "workaround_bios_bug") )
> >              iommu_workaround_bios_bug = 1;
> >          else if ( !strcmp(s, "verbose") )
> > -            iommu_verbose = 1;
> > -        else if ( !strcmp(s, "no-snoop") )
> > -            iommu_snoop = 0;
> > -        else if ( !strcmp(s, "no-qinval") )
> > -            iommu_qinval = 0;
> > -        else if ( !strcmp(s, "no-intremap") )
> > -            iommu_intremap = 0;
> > +            iommu_verbose = val;
> > +        else if ( !strcmp(s, "snoop") )
> > +            iommu_snoop = val;
> > +        else if ( !strcmp(s, "qinval") )
> > +            iommu_qinval = val;
> > +        else if ( !strcmp(s, "intremap") )
> > +            iommu_intremap = val;
> >          else if ( !strcmp(s, "debug") )
> > -            iommu_debug = 1;
> > +            iommu_debug = val;
> >          else if ( !strcmp(s, "amd-iommu-perdev-intremap") )
> > -            amd_iommu_perdev_intremap = 1;
> > +            amd_iommu_perdev_intremap = val;
> >          else if ( !strcmp(s, "dom0-passthrough") )
> > -            iommu_passthrough = 1;
> > +            iommu_passthrough = val;
> >          else if ( !strcmp(s, "dom0-strict") )
> > -            iommu_dom0_strict = 1;
> > +            iommu_dom0_strict = val;
> >          else if ( !strcmp(s, "sharept") )
> > -            iommu_hap_pt_share = 1;
> > +            iommu_hap_pt_share = val;
> >  
> >          s = ss + 1;
> >      } while ( ss );
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel