From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] qemu/configure: fix CFLAGS handling for i386 Date: Sat, 31 Mar 2012 18:46:27 +0200 Message-ID: <20120331164627.GA23873@aepfle.de> References: <20120330152436.GA31016@aepfle.de> <4F772590.2000603@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <4F772590.2000603@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: xen-devel@lists.xensource.com, Erik Blake , qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org On Sat, Mar 31, Andreas Färber wrote: > This is the only usage of += outside Makefile fragments, so I wonder if > its use may have been by accident. Is it safe in a POSIX context? > Or should we better use CFLAGS="$CFLAGS -march=486"? Now that I look at the shebang, configure is a sh script and += is most likely a bash feature. So your suggestion for the assignment is correct. Olaf