From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 14 of 18] tools/libvchan: fix build errors caused by Werror in io.c Date: Mon, 2 Apr 2012 16:37:52 +0200 Message-ID: <20120402143752.GA4000@aepfle.de> References: <0966600a98f1b3a4707f.1333095931@probook.site> <20345.47297.154409.698856@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20345.47297.154409.698856@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Apr 02, Ian Jackson wrote: > Olaf Hering writes ("[Xen-devel] [PATCH 14 of 18] tools/libvchan: fix build errors caused by Werror in io.c"): > > tools/libvchan: fix build errors caused by Werror in io.c > ... > > - writev(-1, iov, 2); > > + if (writev(-1, iov, 2)); > > You need to actually fix these lost error bugs, not just suppress the > warning. The others I havent looked at yet, yes. But this write to fd '-1' one is just for strace. Olaf