From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c
Date: Tue, 3 Apr 2012 11:07:48 +0200 [thread overview]
Message-ID: <20120403090748.GA27810@aepfle.de> (raw)
In-Reply-To: <1333441383.25602.105.camel@zakaz.uk.xensource.com>
On Tue, Apr 03, Ian Campbell wrote:
> On Mon, 2012-04-02 at 20:54 +0100, Olaf Hering wrote:
> > On Mon, Apr 02, Ian Jackson wrote:
> >
> > > Olaf Hering writes ("[Xen-devel] [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c"):
> > > > node-select.c: In function 'vchan_wr':
> > > > node-select.c:60:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> > >
> > > This one is a question of coding style. Apparently libvchan uses
> > > mixed statements/declarations, so this should be fixed by changing the
> > > warning flags.
> However skimming over node-select.c and io.c (as another random file) it
> looks like the use of mixed declarations and code is the exception not
> the rule even within libvchan, so I think it would be fine to fix the
> two places where this isn't the case.
If thats ok with IanJ as well, I will prepare another patch to fix just
that warning in node-select.c
Olaf
next prev parent reply other threads:[~2012-04-03 9:07 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 8:25 [PATCH 00 of 18] tools: fix bugs and build errors triggered by -O2 -Wall -Werror Olaf Hering
2012-03-30 8:25 ` [PATCH 01 of 18] tools/blktap: fix access errors in convert_dev_name_to_num Olaf Hering
2012-04-02 13:47 ` Ian Jackson
2012-04-02 14:04 ` Ian Jackson
2012-04-02 14:42 ` Olaf Hering
2012-04-02 14:44 ` Olaf Hering
2012-04-02 15:04 ` Ian Campbell
2012-04-02 15:08 ` Olaf Hering
2012-04-02 15:16 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 02 of 18] tools/blktap: fix params and physical-device parsing Olaf Hering
2012-04-02 14:38 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 03 of 18] tools/blktap: fix access error in img2qcow.c Olaf Hering
2012-03-30 8:25 ` [PATCH 04 of 18] tools/blktap: fix access error in qcow2raw.c Olaf Hering
2012-03-30 8:25 ` [PATCH 05 of 18] tools/blktap2: fix build errors caused by Werror in vhd_journal_write_entry Olaf Hering
2012-04-02 13:55 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 06 of 18] tools/blktap2: fix out of bounds access in block-log.c Olaf Hering
2012-04-02 14:31 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 07 of 18] tools/blktap2: fix build errors caused by Werror in tdqcow_get_parent_id Olaf Hering
2012-04-02 13:52 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 08 of 18] tools/blktap2: fix access error in img2qcow.c Olaf Hering
2012-03-30 8:25 ` [PATCH 09 of 18] tools/blktap2: fix access error in qcow2raw.c Olaf Hering
2012-03-30 8:25 ` [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c Olaf Hering
2012-04-02 13:59 ` Ian Jackson
2012-04-02 14:40 ` Olaf Hering
2012-04-02 19:54 ` Olaf Hering
2012-04-03 8:23 ` Ian Campbell
2012-04-03 9:07 ` Olaf Hering [this message]
2012-04-03 10:27 ` Ian Jackson
2012-04-03 10:20 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 11 of 18] tools/libxl: fix build errors caused by Werror in disk_eject_xswatch_callback Olaf Hering
2012-04-02 13:53 ` Ian Jackson
2012-04-02 19:58 ` Olaf Hering
2012-04-03 8:30 ` Ian Campbell
2012-04-03 9:11 ` Olaf Hering
2012-04-03 9:24 ` Ian Campbell
2012-04-03 10:28 ` Ian Jackson
2012-04-03 10:21 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 12 of 18] tools/memshr: fix build errors caused by Werror Olaf Hering
2012-04-02 14:39 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 13 of 18] tools/xenpaging: fix build errors caused by -Werror Olaf Hering
2012-04-02 14:01 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 14 of 18] tools/libvchan: fix build errors caused by Werror in io.c Olaf Hering
2012-04-02 14:33 ` Ian Jackson
2012-04-02 14:37 ` Olaf Hering
2012-04-02 14:39 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 15 of 18] tools/blktap2: remove static string table from header file Olaf Hering
2012-04-02 14:32 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 16 of 18] tools/blktap2: fix build errors caused by Werror, remove blkif_op_name Olaf Hering
2012-04-02 14:06 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 17 of 18] tools/blktap2: remove unused labels Olaf Hering
2012-04-02 14:32 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 18 of 18] tools/blktap2: fix build errors caused by Werror, remove unused variables Olaf Hering
2012-03-30 12:44 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403090748.GA27810@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).