From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] tools/vtpm: use LDLIBS to pass -lgmp Date: Tue, 3 Apr 2012 16:07:51 +0200 Message-ID: <20120403140751.GA4553@aepfle.de> References: <6685b67958b0623064c7.1332321259@probook.site> <20346.63753.211063.200875@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20346.63753.211063.200875@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Apr 03, Ian Jackson wrote: > Olaf Hering writes ("[Xen-devel] [PATCH] tools/vtpm: use LDLIBS to pass -lgmp"): > > tools/vtpm: use LDLIBS to pass -lgmp > > > > Linking tpmd will fail with recent toolchains because -lgmp is passed > > via LDFLAGS instead of LDLIBS. With this change -lgpm is placed at the > > end of the gcc cmdline and linking tpmd succeeds again. > ... > > CFLAGS += $(WFLAGS) -g -I.. -I. -O2 -fno-strict-aliasing > > +CFLAGS += -I../../../../tools/vtpm_manager/manager > > - LDFLAGS += -lgmp > > + LDLIBS += -lgmp > > > > -BINDIR := /usr/sbin/ > > +BINDIR := /usr/bin/ > > Please could you make sure not to include unrelated changes in your > patches. That makes the job of the reviewer /much/ harder, because we > would have to inspect every hunk of your patches looking for this kind > of thing creeping in. This patch changes a patch file for vtpm which has LDFLAGS in the context around the changed lines. See the space between the '-' and LDFLAGS. Olaf