From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: [PATCH v2] qemu/configure: fix CFLAGS handling for i386 Date: Tue, 3 Apr 2012 19:32:25 +0200 Message-ID: <20120403173224.GA22140@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: qemu-devel@nongnu.org, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org configure will generate incorrect CFLAGS which will lead to compile errors due to unknown gcc options, iff CFLAGS was already in the environment during configure invocation. Add a space before the -march=i486 gcc option. Remove += operator usage because configure is not a bash script. This patch is against the qemu-xen tree, but it should apply also to qemu.git since it has the same issue. Please apply to both trees. Signed-off-by: Olaf Hering --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu-xen-dir-remote/configure =================================================================== --- qemu-xen-dir-remote.orig/configure +++ qemu-xen-dir-remote/configure @@ -2637,7 +2637,7 @@ int main(int argc, char **argv) } EOF if ! compile_prog "" "" ; then - CFLAGS+="-march=i486" + CFLAGS="$CFLAGS -march=i486" fi fi