From: Tim Deegan <tim@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Gianluca Guida <glguida@gmail.com>,
Andres Lagar-Cavilla <andres@lagarcavilla.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] Re: Shadow domains left zombie
Date: Fri, 20 Apr 2012 09:51:33 +0100 [thread overview]
Message-ID: <20120420085133.GD39206@ocelot.phlegethon.org> (raw)
In-Reply-To: <4F91336D020000780007EC66@nat28.tlf.novell.com>
At 08:59 +0100 on 20 Apr (1334912349), Jan Beulich wrote:
> >>> On 19.04.12 at 19:08, Tim Deegan <tim@xen.org> wrote:
> > At 09:19 -0700 on 13 Apr (1334308772), Andres Lagar-Cavilla wrote:
> >> After a hvm+shadow domain dies (either clean shutdown or merciless
> >> destroy), the domain is left in a zombie state with 1 (one) page left
> >> dangling with a single reference.
> >
> > The reference is to the top-level pagetable that was pointed to by CR3
> > when the domain was killed. This bug came in with:
> >
> > changeset: 23142:f5e8d152a565
> > user: Jan Beulich <jbeulich@novell.com>
> > date: Tue Apr 05 13:01:25 2011 +0100
> > description: x86: split struct vcpu
> >
> > where HVM domains no longer have vcpu_destroy_pagetables(v) called on
> > their VCPUs as they die. Proposed fix attached.
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> I'm sorry for that. Given that this had been quite some time back, I
> can only guess that I got misguided by the fact that
> arch_vcpu_reset() calls this for PV only (legitimately, i.e. not causing
> any leak).
Yeah, it's not exactly clear. Maybe after 4.2 I'll look at making it
more uniform.
Cheers,
Tim.
next prev parent reply other threads:[~2012-04-20 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 16:19 Shadow domains left zombie Andres Lagar-Cavilla
2012-04-13 17:35 ` Gianluca Guida
2012-04-13 17:38 ` Andres Lagar-Cavilla
2012-04-19 17:08 ` [PATCH] " Tim Deegan
2012-04-19 20:10 ` Andres Lagar-Cavilla
2012-04-20 7:59 ` Jan Beulich
2012-04-20 8:51 ` Tim Deegan [this message]
2012-04-20 9:26 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420085133.GD39206@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=JBeulich@suse.com \
--cc=andres@lagarcavilla.org \
--cc=glguida@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).