From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH] Re: Shadow domains left zombie Date: Fri, 20 Apr 2012 09:51:33 +0100 Message-ID: <20120420085133.GD39206@ocelot.phlegethon.org> References: <20120419170840.GD23663@ocelot.phlegethon.org> <4F91336D020000780007EC66@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F91336D020000780007EC66@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Gianluca Guida , Andres Lagar-Cavilla , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org At 08:59 +0100 on 20 Apr (1334912349), Jan Beulich wrote: > >>> On 19.04.12 at 19:08, Tim Deegan wrote: > > At 09:19 -0700 on 13 Apr (1334308772), Andres Lagar-Cavilla wrote: > >> After a hvm+shadow domain dies (either clean shutdown or merciless > >> destroy), the domain is left in a zombie state with 1 (one) page left > >> dangling with a single reference. > > > > The reference is to the top-level pagetable that was pointed to by CR3 > > when the domain was killed. This bug came in with: > > > > changeset: 23142:f5e8d152a565 > > user: Jan Beulich > > date: Tue Apr 05 13:01:25 2011 +0100 > > description: x86: split struct vcpu > > > > where HVM domains no longer have vcpu_destroy_pagetables(v) called on > > their VCPUs as they die. Proposed fix attached. > > Acked-by: Jan Beulich > > I'm sorry for that. Given that this had been quite some time back, I > can only guess that I got misguided by the fact that > arch_vcpu_reset() calls this for PV only (legitimately, i.e. not causing > any leak). Yeah, it's not exactly clear. Maybe after 4.2 I'll look at making it more uniform. Cheers, Tim.