From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@amd64.org>,
"Liu, Jinsong" <jinsong.liu@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Xen-devel] [PATCH 1/3] Add mcelog support for xen platform
Date: Mon, 23 Apr 2012 12:51:28 -0400 [thread overview]
Message-ID: <20120423165128.GA22364@phenom.dumpdata.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F170EF914@ORSMSX104.amr.corp.intel.com>
On Mon, Apr 23, 2012 at 04:17:14PM +0000, Luck, Tony wrote:
> > This driver is _not_ doing a strict bit-by-bit copy of 'struct mcinfo'
> > to 'struct mce'. It is plucking the right bits and setting them in
> > 'struct mce'.
>
> That isn't any worse that what we currently have ... but what we currently
> have is ugly, and doing more ugly things just because we did them before
> generally isn't a winning argument on the mailing lists.
Heh.
Until about an hour ago I did not know that what is there is considered
'ugly' and you guys had thoughts of how to make it nicer. That is good.
And the driver isn't set in stone by only using those function - it can
change.
I am not sure if I have stated, but providing this driver in my mind
is an implicit contract that I, as the sub-maintainer, will keep it
in lock-step with mce.h cleanups. That is after all, the job of a
(sub)-maintainer.
next prev parent reply other threads:[~2012-04-23 16:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 13:29 [PATCH 1/3] Add mcelog support for xen platform Liu, Jinsong
2012-04-20 18:40 ` Konrad Rzeszutek Wilk
2012-04-20 20:00 ` Liu, Jinsong
2012-04-21 4:14 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-04-21 10:45 ` Borislav Petkov
2012-04-23 2:18 ` Konrad Rzeszutek Wilk
2012-04-23 6:09 ` Borislav Petkov
2012-04-23 15:06 ` Konrad Rzeszutek Wilk
2012-04-23 15:59 ` Borislav Petkov
2012-04-23 16:23 ` Luck, Tony
2012-04-23 16:54 ` Konrad Rzeszutek Wilk
2012-04-23 16:17 ` Liu, Jinsong
2012-04-23 15:27 ` Luck, Tony
2012-04-23 15:32 ` Konrad Rzeszutek Wilk
2012-04-23 16:17 ` Luck, Tony
2012-04-23 16:51 ` Konrad Rzeszutek Wilk [this message]
2012-04-23 15:43 ` Liu, Jinsong
2012-04-23 16:26 ` H. Peter Anvin
2012-04-23 17:05 ` Konrad Rzeszutek Wilk
2012-04-23 17:23 ` H. Peter Anvin
2012-04-23 16:17 ` H. Peter Anvin
2012-04-23 17:03 ` Konrad Rzeszutek Wilk
2012-04-23 17:16 ` H. Peter Anvin
2012-04-24 8:27 ` Andi Kleen
2012-04-25 8:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423165128.GA22364@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=bp@amd64.org \
--cc=hpa@zytor.com \
--cc=jinsong.liu@intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).