Re: [hybrid]: code review for function mapping pfn to foreign mfn

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Tue, 24 Apr 2012 10:36:26 +0100
Tim Deegan <tim@xen.org> wrote:

> At 18:37 -0700 on 23 Apr (1335206229), Mukesh Rathor wrote:
> > On Thu, 19 Apr 2012 15:15:27 +0100
> > Tim Deegan <tim@xen.org> wrote:

>you still have this mapping.  You should take a PGT_writeable_page
>typecount, too, if the foreign domain isn't in paging_mode_external

Ok, I've it as:
    if (paging_mode_external(fdom)) {
        if (get_page_from_pagenr(mfn, fdom) == 0)
	    failed = 1;
    } else {
        if (get_page_and_type_from_pagenr(mfn, PGT_writable_page, fdom,0,0))
            failed = 1;
    }

But then later fails when it tries to pin the page,
MMUEXT_PIN_L4_TABLE, from the lib at:

        rc = pin_table(dom->xch, pgd_type,
	                xc_dom_p2m_host(dom, dom->pgtables_seg.pfn),
			dom->guest_domid);

(XEN) mm.c:2424:d0 Bad type (saw 7400000000000001 != exp 4000000000000000) for mfn 1bc160 (pfn 2eed)

thanks,
-m