From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [Xen-devel] [PATCH] xen/apic: implement io apic read with
 hypercall
Date: Tue, 24 Apr 2012 12:23:22 -0400
Message-ID: <20120424162321.GH3213@phenom.dumpdata.com>
References: <1334913957.2863.1.camel@hp6530s>
 <4F913340.4000202@citrix.com>
 <1334920396.2863.16.camel@hp6530s>
 <1334925508.28331.63.camel@zakaz.uk.xensource.com>
 <20120420164150.GC31062@phenom.dumpdata.com>
 <CAF1ivSamaYzQDwjFqRGrnQ+fCr0D4vLGuG4JRBZ3_GD_y8yY=A@mail.gmail.com>
 <20120423151123.GC24481@phenom.dumpdata.com>
 <CAF1ivSY1GAkqU2gN0P22Tb0pmwagam5UUVMABSgnoH3+C+TY+A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAF1ivSY1GAkqU2gN0P22Tb0pmwagam5UUVMABSgnoH3+C+TY+A@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Lin Ming <mlin@ss.pku.edu.cn>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, Apr 24, 2012 at 10:43:53PM +0800, Lin Ming wrote:
> On Mon, Apr 23, 2012 at 11:11 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> >> >> > How about return -1 on error?
> >> >> > The calling function can check -1 for error.
> >> >>
> >> >> Isn't -1 potentially (at least theoretically) a valid value to =
read from
> >> >> one of these registers?
> >> >
> >> > Yeah, but then we are back to crashing at bootup (with dom0) :-)
> >> >
> >> > Perhaps the fallback is to emulate (so retain some of the origin=
al code)
> >> > as we have been since .. uh 3.0?
> >>
> >> Do you mean the return value of io_apic_read in 3.0?
> >
> > No. I meant that we would continue to emulate. The improvement
> > is that now we do:
> >
> > =A0 =A0 =A0 if (reg =3D=3D 0x1)
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 return 0x00170020;
> > =A0 =A0 =A0 else if (reg =3D=3D 0x0)
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 return apic << 24;
> >
> > instead of 0xfdfdfdfd.
> >
> >> It's 0xffffffff.
> >
> > Now it is 0xfdfdfdfd.
> >
> > I am suggesting that instead of BUG_ON(), we fallback to do returni=
ng
> > an emulatated IO_APIC values - like the ones that this original pat=
ch
> > cooked up..
>=20
> But we still need to return some value if the register is not emulate=
d.

Right. 0xfd;
>=20
> How about below?


Almost perfect.
>=20
> unsigned int xen_io_apic_read(unsigned apic, unsigned reg)
> {
>         struct physdev_apic apic_op;
>         int ret;
>=20
>         apic_op.apic_physbase =3D mpc_ioapic_addr(apic);
>         apic_op.reg =3D reg;
>         ret =3D HYPERVISOR_physdev_op(PHYSDEVOP_apic_read, &apic_op);
>         if (!ret)
>                 return apic_op.value;
>=20
>         /* emulate register */
>         if (reg =3D=3D 0x1)
>                 return 0x00170020;
>         else if (reg =3D=3D 0x0)
>                 return apic << 24;
>         else
>                 return -1;

	return 0xfd;
> }