From: Tim Deegan <tim@xen.org>
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: andres@gridcentric.ca, xen-devel@lists.xen.org
Subject: Re: [PATCH 1 of 2] x86/mem_sharing: Fix saved mfns stat for failed unsharing
Date: Thu, 26 Apr 2012 10:13:10 +0100 [thread overview]
Message-ID: <20120426091310.GC67043@ocelot.phlegethon.org> (raw)
In-Reply-To: <5be9a05f17fd38f9c09f.1335295218@xdev.gridcentric.ca>
At 15:20 -0400 on 24 Apr (1335280818), Andres Lagar-Cavilla wrote:
> xen/arch/x86/mm/mem_sharing.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>
> If unsharing fails, the decrease of the nr_saved_mfns stat was not being
> undone. This would result in an underflow of the stat, as the retry would later
> decrease the counter again.
Applied, thanks.
next prev parent reply other threads:[~2012-04-26 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 19:20 [PATCH 0 of 2] Sharing bug fixes Andres Lagar-Cavilla
2012-04-24 19:20 ` [PATCH 1 of 2] x86/mem_sharing: Fix saved mfns stat for failed unsharing Andres Lagar-Cavilla
2012-04-26 9:13 ` Tim Deegan [this message]
2012-04-24 19:20 ` [PATCH 2 of 2] x86/mem_sharing: Rectify test for "empty" physmap entry in sharing_add_to_physmap Andres Lagar-Cavilla
2012-04-25 12:41 ` Tim Deegan
2012-04-25 15:20 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426091310.GC67043@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=andres@gridcentric.ca \
--cc=andres@lagarcavilla.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).