From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 1 of 2] x86/mem_sharing: Fix saved mfns stat for failed unsharing Date: Thu, 26 Apr 2012 10:13:10 +0100 Message-ID: <20120426091310.GC67043@ocelot.phlegethon.org> References: <5be9a05f17fd38f9c09f.1335295218@xdev.gridcentric.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5be9a05f17fd38f9c09f.1335295218@xdev.gridcentric.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andres Lagar-Cavilla Cc: andres@gridcentric.ca, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org At 15:20 -0400 on 24 Apr (1335280818), Andres Lagar-Cavilla wrote: > xen/arch/x86/mm/mem_sharing.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > If unsharing fails, the decrease of the nr_saved_mfns stat was not being > undone. This would result in an underflow of the stat, as the retry would later > decrease the counter again. Applied, thanks.