From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 0 of 2] Add libxc API that sets mem_access type for an array of gfns Date: Fri, 27 Apr 2012 09:48:32 +0100 Message-ID: <20120427084832.GA86045@ocelot.phlegethon.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Aravindh Puthiyaparambil Cc: Christian.Limpach@gmail.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org At 18:36 -0700 on 26 Apr (1335465381), Aravindh Puthiyaparambil wrote: > > - this is wrong: > > > - old_entry = *ept_entry; > > > + old_entry->epte = ept_entry->epte; > > You should follow the code and see what uses old_entry and you'll see > > that within the function old_entry->mfn is used (your diff changes the > > line that uses it) and ept_free_entry also accesses mfn. > > I will fix that. > > > - are you sure you can move the ept_sync_domain call past the iommu code? > > > > I was hoping Tim would give me feedback about that. I'm afraid I won't be able to review this code until next week. This change is already too late for the 4.2 freeze, though, so there's plenty of time to get it right after we branch. Cheers, Tim.