xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Jan Beulich <jbeulich@suse.com>,
	Stefan Bader <stefan.bader@canonical.com>
Subject: Re: Workings/effectiveness of the xen-acpi-processor driver
Date: Tue, 1 May 2012 20:47:12 -0400	[thread overview]
Message-ID: <20120502004712.GA15950@phenom.dumpdata.com> (raw)
In-Reply-To: <20120501225456.GA13757@phenom.dumpdata.com>

On Tue, May 01, 2012 at 06:54:56PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, May 01, 2012 at 06:35:45PM -0400, Boris Ostrovsky wrote:
> > On 05/01/2012 04:02 PM, Konrad Rzeszutek Wilk wrote:
> > >On Thu, Apr 26, 2012 at 06:25:28PM +0200, Stefan Bader wrote:
> > >>On 26.04.2012 17:50, Konrad Rzeszutek Wilk wrote:
> > >>>On Wed, Apr 25, 2012 at 03:00:58PM +0200, Stefan Bader wrote:
> > >>>>Since there have been requests about that driver to get backported into 3.2, I
> > >>>>was interested to find out what or how much would be gained by that.
> > >>>>
> > >>>>The first system I tried was an AMD based one (8 core Opteron 6128@2GHz). Which
> > >>>>was not very successful as the drivers bail out of the init function because the
> > >>>>first call to acpi_processor_register_performance() returns -ENODEV. There is
> > >>>>some frequency scaling when running without Xen, so I need to do some more
> > >>>>debugging there.
> > 
> > I believe this is caused by the somewhat under-enlightened xen_apic_read():
> > 
> > static u32 xen_apic_read(u32 reg)
> > {
> >         return 0;
> > }
> > 
> > This results in some data, most importantly
> > boot_cpu_physical_apicid, not being set correctly and, in turn,
> > causes x86_cpu_to_apicid to be broken.
> 
> What is the involvment of x86_cpu_to_apicid to acpi_processor_register_performance?
> Or is this more of a stab in the dark?

Ah, it is the acpi_get_cpuid that gets called by acpi_processor_add->acpi_processor_get_info.

And this one:
201 #ifdef CONFIG_SMP
202         for_each_possible_cpu(i) {
203                 if (cpu_physical_id(i) == apic_id)
204                         return i;
205         }               
206 #else   

where the cpu_physical_id(i) is per_cpu(x86_cpu_to_apicid, i).

But it is curious that it has been working for me on AMD and Intel machines.
Granted the only server boxes I've are Intel - don't have AMD server boxes at all.

Stefan, can you send the full dmesg output too please?

  reply	other threads:[~2012-05-02  0:47 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 13:00 Workings/effectiveness of the xen-acpi-processor driver Stefan Bader
2012-04-26 15:50 ` Konrad Rzeszutek Wilk
2012-04-26 16:25   ` Stefan Bader
2012-04-26 17:04     ` Konrad Rzeszutek Wilk
2012-05-06 15:23       ` Pasi Kärkkäinen
2012-05-07 17:33         ` Konrad Rzeszutek Wilk
2012-05-07 17:44           ` Pasi Kärkkäinen
2012-05-01 20:02     ` Konrad Rzeszutek Wilk
2012-05-01 22:35       ` Boris Ostrovsky
2012-05-01 22:54         ` Konrad Rzeszutek Wilk
2012-05-02  0:47           ` Konrad Rzeszutek Wilk [this message]
2012-05-02  1:11             ` Boris Ostrovsky
2012-05-02  9:19               ` Jan Beulich
2012-05-02 14:56           ` Stefan Bader
2012-05-02  8:36         ` Stefan Bader
2012-05-02 15:01         ` Stefan Bader
2012-05-02 16:08           ` Konrad Rzeszutek Wilk
2012-05-02 17:06             ` Boris Ostrovsky
2012-05-02 17:14               ` Konrad Rzeszutek Wilk
2012-05-02 21:31                 ` Boris Ostrovsky
2012-05-02 21:41                   ` Konrad Rzeszutek Wilk
2012-05-02 22:09                     ` Boris Ostrovsky
2012-05-03  6:55                       ` Stefan Bader
2012-05-03 10:00                         ` Stefan Bader
2012-05-03 12:58                       ` Stefan Bader
2012-05-03 14:47                         ` Stefan Bader
2012-05-03 15:46                           ` Konrad Rzeszutek Wilk
2012-05-03 17:02                             ` Boris Ostrovsky
2012-05-03 17:08                             ` Konrad Rzeszutek Wilk
2012-05-04  8:00                               ` Stefan Bader
2012-05-03 16:14                       ` Konrad Rzeszutek Wilk
2012-05-02 21:29             ` Stefan Bader
2012-05-02  8:22       ` Stefan Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120502004712.GA15950@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=boris.ostrovsky@amd.com \
    --cc=jbeulich@suse.com \
    --cc=stefan.bader@canonical.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).