From: Goncalo Gomes <Goncalo.Gomes@EU.CITRIX.COM>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: libxl parser question
Date: Sun, 6 May 2012 22:23:37 +0100 [thread overview]
Message-ID: <20120506212337.GA15262@eire.uk.xensource.com> (raw)
In-Reply-To: <1336296147.5933.5.camel@cthulhu.hellion.org.uk>
On Sun, 06 May 2012, Ian Campbell wrote:
> I've tried reproducing using your config file with the patch applied and
> I can't.
>
> > [...]
> > This abort is the `default` case in the switch at xl_cmdimpl.c:736,
> > which gets triggered from an erroneous b_info->type with a bogus value
> > of 0x84 (which is neither PV nor HVM.)
>
> I think it might be useful to sprinkle prints of b_info->type everywhere
> from the call to libxl_domain_build_info_init_type up until this switch
> statement to see if you can identify the line which is overwriting this
> field. I couldn't spot it by eye but something in there is presumably
> blowing off the end of a buffer or something similar.
>
> You should probably also validate the initial value, which comes from
> c_info->type, and if that is wrong trace it back to the place which sets
> that initial value.
Running 'make install' after various attempts seems to have done it.
I was all along under the impression that the dynamic linker would
pick the libxenlight in the current dir, which is why I hadn't run
'make install' every so often, but did instead occasionally run 'make
clean all' Coming to think of it, if the DLD was to pick the library
from the current directory, a world of security bugs and pain would
ensue, but for some reason I kept expecting the behaviour to be that.
Thanks though!
Goncalo
next prev parent reply other threads:[~2012-05-06 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 23:19 libxl parser question Goncalo Gomes
2012-05-06 9:22 ` Ian Campbell
2012-05-06 21:23 ` Goncalo Gomes [this message]
2012-05-08 10:55 ` Ian Campbell
2012-05-08 12:37 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506212337.GA15262@eire.uk.xensource.com \
--to=goncalo.gomes@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).