From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH] x86/mem_sharing: Rectify test for "empty" physmap entry in sharing_add_to_physmap Date: Wed, 23 May 2012 17:17:27 +0100 Message-ID: <20120523161727.GA48125@ocelot.phlegethon.org> References: <3169fba29613241b69ac.1337177132@xdev.gridcentric.ca> <20120517094033.GA57529@ocelot.phlegethon.org> <7b80441999d6300fa6b8380bd96a22a5.squirrel@webmail.lagarcavilla.org> <20120517120249.GE57529@ocelot.phlegethon.org> <20120518152203.GA40048@ocelot.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andres Lagar-Cavilla Cc: andres@gridcentric.ca, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org At 07:34 -0700 on 23 May (1337758450), Andres Lagar-Cavilla wrote: > > At 08:55 -0700 on 17 May (1337244911), Andres Lagar-Cavilla wrote: > >> # HG changeset patch > >> # Parent 485cd11f131da88b286b3b64e8f095508b67ab0b > >> x86/mem_sharing: Re-rectify sharing add to physmap hole test. > >> > >> Signed-off-by: Andres Lagar-Cavilla > > > > Applied, thanks. I gave it a slightly fuller description and fixed some > > whitespace around parentheses on the way past. > > > > I think that empties the queue, at least of things that are wanted for > > 4.2. > > Actually, patch 6 of this series posted a while ago > http://lists.xen.org/archives/html/xen-devel/2012-04/msg01364.html > http://lists.xen.org/archives/html/xen-devel/2012-04/msg00962.html > > turns on locking p2m queries for shadow mode and seemingly you've acked > it. This is good to go afaict and would be a shame to be left off of 4.2. I think I'll leave it out for now. Shadow doesn't coexist with paging/sharing/memattr and already has its own interlocks against everything else so it's not a bugfix. Cheers, Tim.