* Re: [PATCH] xen: add bridge check
@ 2012-05-25 2:05 Zhang, Yang Z
2012-05-25 2:28 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Yang Z @ 2012-05-25 2:05 UTC (permalink / raw)
To: Zhang, Yang Z, xen-devel@lists.xensource.com; +Cc: Konrad Rzeszutek Wilk
Hi konrad,
Any comments with this patch?
best regards
yang
> -----Original Message-----
> From: Zhang, Yang Z
> Sent: Tuesday, May 22, 2012 4:40 PM
> To: xen-devel@lists.xensource.com
> Cc: Konrad Rzeszutek Wilk [konrad.wilk@oracle.com]
> Subject: [PATCH] xen: add bridge check
>
> Some SR-IOV devices may use more than one bus number, but there is no real
> bridges
> because that have internal routing mechanism. So need to check whether the
> bridge is
> existing before using it.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
> ---
> drivers/xen/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
> index b84bf0b..18fff88 100644
> --- a/drivers/xen/pci.c
> +++ b/drivers/xen/pci.c
> @@ -59,7 +59,7 @@ static int xen_add_device(struct device *dev)
>
> #ifdef CONFIG_ACPI
> handle = DEVICE_ACPI_HANDLE(&pci_dev->dev);
> - if (!handle)
> + if (!handle && pci_dev->bus->bridge)
> handle = DEVICE_ACPI_HANDLE(pci_dev->bus->bridge);
> #ifdef CONFIG_PCI_IOV
> if (!handle && pci_dev->is_virtfn)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen: add bridge check
2012-05-25 2:05 [PATCH] xen: add bridge check Zhang, Yang Z
@ 2012-05-25 2:28 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-05-25 2:28 UTC (permalink / raw)
To: Zhang, Yang Z; +Cc: xen-devel@lists.xensource.com
On Fri, May 25, 2012 at 02:05:17AM +0000, Zhang, Yang Z wrote:
> Hi konrad,
> Any comments with this patch?
Looks good. applied.
>
> best regards
> yang
>
> > -----Original Message-----
> > From: Zhang, Yang Z
> > Sent: Tuesday, May 22, 2012 4:40 PM
> > To: xen-devel@lists.xensource.com
> > Cc: Konrad Rzeszutek Wilk [konrad.wilk@oracle.com]
> > Subject: [PATCH] xen: add bridge check
> >
> > Some SR-IOV devices may use more than one bus number, but there is no real
> > bridges
> > because that have internal routing mechanism. So need to check whether the
> > bridge is
> > existing before using it.
> >
> > Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
> > ---
> > drivers/xen/pci.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
> > index b84bf0b..18fff88 100644
> > --- a/drivers/xen/pci.c
> > +++ b/drivers/xen/pci.c
> > @@ -59,7 +59,7 @@ static int xen_add_device(struct device *dev)
> >
> > #ifdef CONFIG_ACPI
> > handle = DEVICE_ACPI_HANDLE(&pci_dev->dev);
> > - if (!handle)
> > + if (!handle && pci_dev->bus->bridge)
> > handle = DEVICE_ACPI_HANDLE(pci_dev->bus->bridge);
> > #ifdef CONFIG_PCI_IOV
> > if (!handle && pci_dev->is_virtfn)
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] xen: add bridge check
@ 2012-05-22 8:40 Zhang, Yang Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Yang Z @ 2012-05-22 8:40 UTC (permalink / raw)
To: xen-devel@lists.xensource.com; +Cc: Konrad Rzeszutek Wilk
Some SR-IOV devices may use more than one bus number, but there is no real bridges
because that have internal routing mechanism. So need to check whether the bridge is
existing before using it.
Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
---
drivers/xen/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
index b84bf0b..18fff88 100644
--- a/drivers/xen/pci.c
+++ b/drivers/xen/pci.c
@@ -59,7 +59,7 @@ static int xen_add_device(struct device *dev)
#ifdef CONFIG_ACPI
handle = DEVICE_ACPI_HANDLE(&pci_dev->dev);
- if (!handle)
+ if (!handle && pci_dev->bus->bridge)
handle = DEVICE_ACPI_HANDLE(pci_dev->bus->bridge);
#ifdef CONFIG_PCI_IOV
if (!handle && pci_dev->is_virtfn)
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-25 2:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-25 2:05 [PATCH] xen: add bridge check Zhang, Yang Z
2012-05-25 2:28 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2012-05-22 8:40 Zhang, Yang Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).