From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Date: Wed, 30 May 2012 17:05:20 +0200 Message-ID: <20120530150520.GC15438@x1.osrc.amd.com> References: <1338383402-3838-1-git-send-email-andre.przywara@amd.com> <4FC631D3.9080907@zytor.com> <20120530145523.GA15635@x1.osrc.amd.com> <4FC6358F.2010405@zytor.com> <20120530150007.GB15438@x1.osrc.amd.com> <4FC6363F.3040208@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <4FC6363F.3040208@zytor.com> Sender: linux-kernel-owner@vger.kernel.org To: "H. Peter Anvin" Cc: Andre Przywara , mingo@elte.hu, tglx@linutronix.de, konrad.wilk@oracle.com, jeremy@goop.org, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, stable@vger.kernel.org List-Id: xen-devel@lists.xenproject.org On Wed, May 30, 2012 at 08:01:19AM -0700, H. Peter Anvin wrote: > >> I'm not following: If the AMD variants (putting a special value into > >> %edi) can be freely replaced by the non-AMD variants, why did > >> the AMD special ones get used in the first place? > > > Older CPUs (K8) needed the AMD variants, starting with family 10h we > > can use the normal versions. > > So no, not correct. I don't see what the problem is: the amd* variants shouldn't have been used at all in the first place. Fullstop. The patch should've been doing *msrl_safe from the get-go. Regardless of family. So what's the issue? -- Regards/Gruss, Boris.