From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (RFC) Date: Wed, 30 May 2012 17:29:48 +0200 Message-ID: <20120530152948.GD4771@aftab.osrc.amd.com> References: <20120524184947.GA28338@phenom.dumpdata.com> <20120525180102.GA27280@phenom.dumpdata.com> <20120529133858.GD29157@aftab.osrc.amd.com> <20120530150827.GA12109@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Liu, Jinsong" Cc: Konrad Rzeszutek Wilk , "'linux-kernel@vger.kernel.org'" , "Luck, Tony" , "'xen-devel@lists.xensource.com'" List-Id: xen-devel@lists.xenproject.org On Wed, May 30, 2012 at 03:20:03PM +0000, Liu, Jinsong wrote: > >> IMO currently there are 2 options: > >> 1). use the original approach (implicitly redirect /dev/mcelog to > >> xen_mce_chrdev_device) --> what point of this approach do you think > >> unreasonable? It just remove a 'static' from native mce code! 2). > >> use another /dev/xen-mcelog interface, with another misc minor '226' > > > > The 2) is no good. > > > > 3) What about moving the corresponding other users (so > > threshold_init_device), to be at late_initcall and the mce to be at > > late_initcall_sync > > I can try, but only if Boris would not jump out. > and it can only be tested by Boris at AMD platform :( Sure, I'll test it. However, it should be a separate patch, not merged with this one. So, I don't see anything speaking against making threshold_init_device a late_initcall leading to the following order: device_initcall <- xen device_initcall_sync <- arch/x86 fs_initcall <- threshold_init_device and the "xen" line not happening on baremetal; which shouldn't change anything noticeably in the init-order mce-wise. Also, add a comment at the end of mce_amd.c saying why threshold_init_device should be last. Thanks. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551