From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: Xen 4.2 TODO / Release Plan
Date: Thu, 31 May 2012 11:24:27 +0200
Message-ID: <20120531092427.GA5937@aepfle.de>
References: <1336991215.31817.59.camel@zakaz.uk.xensource.com>
	<4FB1052D02000078000836D8@nat28.tlf.novell.com>
	<1338283962.14158.86.camel@zakaz.uk.xensource.com>
	<4FC4BCB002000078000868E0@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <4FC4BCB002000078000868E0@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, May 29, Jan Beulich wrote:

> >>> On 29.05.12 at 11:32, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > On Mon, 2012-05-14 at 12:14 +0100, Jan Beulich wrote:
> >> 
> >> >>> On 14.05.12 at 12:26, Ian Campbell <Ian.Campbell@citrix.com>
> >> wrote:
> >> > tools, blockers:
> >> 
> >> Adjustments needed for qdisk backend to work on non-pvops Linux.
> > 
> > Can you remind me what those are please.
> 
> "qemu/xendisk: set maximum number of grants to be used"
> (http://lists.xen.org/archives/html/xen-devel/2012-05/msg00715.html).
> 
> Unfortunately I didn't hear back from Olaf regarding the updated
> value that the supposed v2 of the patch (see the thread), which
> is at least partly due to him having further problems with the qdisk
> backend. Olaf - did you ever see gntdev allocation failures again
> after switching to the higher value?

I just did a successful installation of sles11sp2 guest on a
xen-unstable host with changeset 25427:ad348c6575b8, and with the change
below, and the second attempt I just started seems get through as well.

I'm sure I used this variant already two weeks ago, and the install
still failed. Perhaps other changes made during the last two weeks make
a difference.

I will also doublecheck how it goes without this change.

Olaf

--- a/hw/xen_disk.c
+++ b/hw/xen_disk.c
@@ -536,6 +536,10 @@ static void blk_alloc(struct XenDevice *
     if (xen_mode != XEN_EMULATE) {
         batch_maps = 1;
     }
+    if (xc_gnttab_set_max_grants(xendev->gnttabdev,
+               2 * max_requests * BLKIF_MAX_SEGMENTS_PER_REQUEST + 1) < 0)
+        xen_be_printf(xendev, 0, "xc_gnttab_set_max_grants failed: %s\n",
+                      strerror(errno));
 }

 static int blk_init(struct XenDevice *xendev)