From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>,
Borislav Petkov <bp@amd64.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 1/2] xen/mce: Add mcelog support for Xen platform
Date: Thu, 31 May 2012 14:54:44 -0400 [thread overview]
Message-ID: <20120531185444.GA7557@phenom.dumpdata.com> (raw)
In-Reply-To: <DE8DF0795D48FD4CA783C40EC82923352000E2@SHSMSX101.ccr.corp.intel.com>
> >> That's vMCE injection logic.
> >
> > Are you sure about it? The comments in it speak of piggybacking on
> > the native MCE handling routines. But since that is not used anymore
> > do you need to use a different mechanism?
>
> What is not used anymore? what's your concern about cvt_gate_to_trap? I really confused here.
> Could you elaborate more?
Well, the mce.c is not involved anymore. So if it we are piggybacking
on the native MCE handling routines - those routines (do_machine_check)
won't deliever the data to your driver anymore? B/c the do_machine_check
is doing mce_log which spools data. But your driver is using a different
system to de-spool the data - and it does not use the mcelog structure
array.
.. snip.
> >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >> c/s a01ee165a132fadb57659d26246e340d6ac53265
> >
> > Which I think the tree is based on too.
>
> So it would not be stuck?
I've no idea what you mean here. Could you elaborate please?
next prev parent reply other threads:[~2012-05-31 18:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 12:57 [PATCH 1/2] xen/mce: Add mcelog support for Xen platform Liu, Jinsong
2012-05-31 13:50 ` Borislav Petkov
2012-05-31 15:30 ` Konrad Rzeszutek Wilk
2012-05-31 16:11 ` Konrad Rzeszutek Wilk
2012-05-31 17:27 ` Liu, Jinsong
2012-05-31 17:31 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-05-31 18:08 ` Liu, Jinsong
2012-05-31 18:54 ` Konrad Rzeszutek Wilk [this message]
2012-06-01 7:57 ` Liu, Jinsong
2012-06-06 20:55 ` Konrad Rzeszutek Wilk
2012-06-07 6:45 ` Liu, Jinsong
2012-06-07 17:20 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-06-08 9:27 ` Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531185444.GA7557@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=bp@amd64.org \
--cc=jinsong.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).