From: Tim Deegan <tim@xen.org>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 2 of 2 RFC] xen, pod: Only sweep in an emergency, and only for 4k pages
Date: Thu, 14 Jun 2012 10:11:31 +0100 [thread overview]
Message-ID: <20120614091131.GD82539@ocelot.phlegethon.org> (raw)
In-Reply-To: <6e760eb25dac400f4873.1339155933@exile>
At 11:45 +0000 on 08 Jun (1339155933), George Dunlap wrote:
> + if ( p2m->pod.count == 0 )
> + goto out_of_memory;
>
> /* Keep track of the highest gfn demand-populated by a guest fault */
> if ( gfn > p2m->pod.max_guest )
> p2m->pod.max_guest = gfn;
>
> - if ( p2m->pod.count == 0 )
> - goto out_of_memory;
> -
Is this code motion just noise? Since out_of_memory crasheds the guest,
I assume so.
Cheers,
Tim.
next prev parent reply other threads:[~2012-06-14 9:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 11:45 [PATCH 0 of 2 RFC] Rework populate-on-demand sweeping George Dunlap
2012-06-08 11:45 ` [PATCH 1 of 2 RFC] xen, pod: Zero-check recently populated pages (checklast) George Dunlap
2012-06-08 12:02 ` Jan Beulich
2012-06-14 9:07 ` Tim Deegan
2012-06-14 14:24 ` George Dunlap
2012-06-14 15:36 ` Tim Deegan
2012-06-08 11:45 ` [PATCH 2 of 2 RFC] xen, pod: Only sweep in an emergency, and only for 4k pages George Dunlap
2012-06-14 9:11 ` Tim Deegan [this message]
2012-06-14 12:42 ` George Dunlap
2012-06-14 13:13 ` Tim Deegan
2012-06-14 13:32 ` George Dunlap
2012-06-14 9:12 ` [PATCH 0 of 2 RFC] Rework populate-on-demand sweeping Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614091131.GD82539@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).