From: Tim Deegan <tim@xen.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
xen-devel@lists.xensource.com,
Andres Lagar-Cavilla <andres@lagarcavilla.org>
Subject: Re: [PATCH 2 of 4 RFC] xen, pod: Check zero-check pages returned by the balloon driver
Date: Thu, 14 Jun 2012 14:20:56 +0100 [thread overview]
Message-ID: <20120614132056.GD90181@ocelot.phlegethon.org> (raw)
In-Reply-To: <20120614131923.GA9349@aepfle.de>
At 15:19 +0200 on 14 Jun (1339687163), Olaf Hering wrote:
> On Thu, Jun 14, Tim Deegan wrote:
>
> > At 12:54 +0100 on 08 Jun (1339160092), George Dunlap wrote:
> > > + else if( p2m_is_ram(t) )
> > > + {
> > > + if ( steal_for_cache )
> > > + {
> > > + struct page_info *page;
> > > +
> > > + ASSERT(mfn_valid(mfn));
> >
> > I think this assertion is broken by the paging code, which adds
> > paged-out pages to the RAM types. One fix is to undo that change and
> > have p2m_is_ram() only be true for present pages, but I think for 4.2 it
> > would be less disruptive to test here for the paged-out and paging
> > types.
>
> I assume the posted hunk is in PoD code, for 4.2 it should be fine
> because paging cant be enabled if PoD is already enabled.
Good point. OK, we can ignore it for now and sort it all out after 4.2
Cheers,
Tim.
next prev parent reply other threads:[~2012-06-14 13:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 11:54 [PATCH 0 of 4 RFC] Populate-on-demand: Check pages being returned by the balloon driver George Dunlap
2012-06-08 11:54 ` [PATCH 1 of 4 RFC] xen, p2m: get_entry returns level of entry as well George Dunlap
2012-06-14 10:21 ` Tim Deegan
2012-06-14 15:01 ` George Dunlap
2012-06-14 15:31 ` Tim Deegan
2012-06-14 16:39 ` George Dunlap
2012-06-14 17:00 ` Tim Deegan
2012-06-08 11:54 ` [PATCH 2 of 4 RFC] xen, pod: Check zero-check pages returned by the balloon driver George Dunlap
2012-06-14 10:28 ` Tim Deegan
2012-06-14 12:57 ` Andres Lagar-Cavilla
2012-06-14 13:19 ` Tim Deegan
2012-06-14 13:19 ` Olaf Hering
2012-06-14 13:20 ` Tim Deegan [this message]
2012-06-08 11:54 ` [PATCH 3 of 4 RFC] imported patch CA-72761-libxc-error.patch George Dunlap
2012-06-08 11:57 ` George Dunlap
2012-06-08 11:54 ` [PATCH 4 of 4 RFC] imported patch pygrub-invalid-disk-catch.patch George Dunlap
2012-06-08 11:58 ` George Dunlap
2012-06-08 11:58 ` [PATCH 0 of 4 RFC] Populate-on-demand: Check pages being returned by the balloon driver George Dunlap
2012-06-14 10:14 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614132056.GD90181@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=andres@lagarcavilla.org \
--cc=george.dunlap@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).