From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastian Blank Subject: Re: [PATCH] Fix asmlinkage functions Date: Wed, 20 Jun 2012 10:12:59 +0200 Message-ID: <20120620081258.GA2521@wavehammer.waldi.eu.org> References: <20120619191253.GA22807@wavehammer.waldi.eu.org> <4FE19F1B020000780008ABEC@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4FE19F1B020000780008ABEC@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Jun 20, 2012 at 08:59:55AM +0100, Jan Beulich wrote: > Iirc Keir had already taken steps towards removing all the > (pointless) asmlinkage annotations, so if there are any left I > think we'd rather see them removed than made consistent. I see a lot of them and always not on both declaration and definition. | xen/arch/arm/traps.c:asmlinkage void __div0(void) | xen/arch/arm/traps.c:asmlinkage void do_trap_undefined_instruction(struct cpu_user_regs *regs) | xen/arch/arm/traps.c:asmlinkage void do_trap_supervisor_call(struct cpu_user_regs *regs) | xen/arch/arm/traps.c:asmlinkage void do_trap_prefetch_abort(struct cpu_user_regs *regs) | xen/arch/arm/traps.c:asmlinkage void do_trap_data_abort(struct cpu_user_regs *regs) | xen/arch/arm/traps.c:asmlinkage void do_trap_hypervisor(struct cpu_user_regs *regs) | xen/arch/arm/traps.c:asmlinkage void do_trap_irq(struct cpu_user_regs *regs) | xen/arch/arm/traps.c:asmlinkage void do_trap_fiq(struct cpu_user_regs *regs) | xen/arch/arm/traps.c:asmlinkage void leave_hypervisor_tail(void) | xen/common/softirq.c:asmlinkage void do_softirq(void) | xen/include/acpi/acpixf.h:acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state); | xen/include/acpi/acpixf.h:acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void); | xen/include/xen/softirq.h:asmlinkage void do_softirq(void); It is not longer problematic because asmlinkage is always defined empty, but it is still there. Bastian -- We have found all life forms in the galaxy are capable of superior development. -- Kirk, "The Gamesters of Triskelion", stardate 3211.7