From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Xen-devel] [PATCH 1/1] xen/netback: only non-freed SKB is queued into tx_queue Date: Thu, 28 Jun 2012 16:55:50 -0700 (PDT) Message-ID: <20120628.165550.1816352825092253548.davem@davemloft.net> References: <1340794018-17274-1-git-send-email-annie.li@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340794018-17274-1-git-send-email-annie.li@oracle.com> Sender: netdev-owner@vger.kernel.org To: annie.li@oracle.com Cc: xen-devel@lists.xensource.com, netdev@vger.kernel.org, Ian.Campbell@citrix.com, konrad.wilk@oracle.com, kurt.hackel@oracle.com List-Id: xen-devel@lists.xenproject.org From: annie.li@oracle.com Date: Wed, 27 Jun 2012 18:46:58 +0800 > From: Annie Li > > After SKB is queued into tx_queue, it will be freed if request_gop is NULL. > However, no dequeue action is called in this situation, it is likely that > tx_queue constains freed SKB. This patch should fix this issue, and it is > based on 3.5.0-rc4+. > > This issue is found through code inspection, no bug is seen with it currently. > I run netperf test for several hours, and no network regression was found. > > Signed-off-by: Annie Li I lack the expertiece necessary to properly review this, so I really need a Xen expert to look this over.