From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian.Campbell@citrix.com, x86@kernel.org,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH] extend_brk and fixes to users of extend_brk (v1).
Date: Tue, 31 Jul 2012 13:29:16 -0400 [thread overview]
Message-ID: <20120731172916.GD29533@phenom.dumpdata.com> (raw)
In-Reply-To: <501826EF0200007800091AE9@nat28.tlf.novell.com>
On Tue, Jul 31, 2012 at 05:41:51PM +0100, Jan Beulich wrote:
> >>> On 31.07.12 at 18:15, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > On Tue, Jul 31, 2012 at 08:49:21AM -0700, H. Peter Anvin wrote:
> >> This means you're either abusing the brk allocator to do something
> >> it is not meant to do... which may mean you can a failure in *other*
> >> code, or you have a bug in your code that you haven't fixed.
> >
> > Its the latter - and of one of the patches in this patchset fixes that.
>
> But then you also can't assume that fitting a 2Gb MMIO hole will
> suffice; I have a machine here that I can configure to have a
> 3Gb hole, so I think you really need to be on the safe side and
> allow to cover all the way up to 4Gb with the space you reserve.
I have a patch to address that were the P2M leafs are re-used (the
ones that either full of 1:1 PFNs or INVALID_P2M_ENTRY). But
somehow its hitting a bug..
>
> Jan
prev parent reply other threads:[~2012-07-31 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 10:42 [PATCH] extend_brk and fixes to users of extend_brk (v1) Konrad Rzeszutek Wilk
2012-07-31 10:42 ` [PATCH 1/3] xen/mmu/p2m: Check extend_brk for NULL Konrad Rzeszutek Wilk
2012-07-31 13:48 ` Konrad Rzeszutek Wilk
2012-07-31 10:42 ` [PATCH 2/3] xen/p2m: Reserve 4MB of _brk space for P2M leafs when populating back Konrad Rzeszutek Wilk
2012-07-31 10:42 ` [PATCH 3/3] x86: Let extend_brk return a NULL pointer instead of just BUG_ON Konrad Rzeszutek Wilk
2012-07-31 15:49 ` [PATCH] extend_brk and fixes to users of extend_brk (v1) H. Peter Anvin
2012-07-31 16:15 ` Konrad Rzeszutek Wilk
2012-07-31 16:41 ` [Xen-devel] " Jan Beulich
2012-07-31 17:29 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731172916.GD29533@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).