From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH] extend_brk and fixes to users of extend_brk (v1). Date: Tue, 31 Jul 2012 13:29:16 -0400 Message-ID: <20120731172916.GD29533@phenom.dumpdata.com> References: <1343731376-20658-1-git-send-email-konrad.wilk@oracle.com> <5017FE81.3080903@zytor.com> <20120731161515.GQ4789@phenom.dumpdata.com> <501826EF0200007800091AE9@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <501826EF0200007800091AE9@nat28.tlf.novell.com> Sender: linux-kernel-owner@vger.kernel.org To: Jan Beulich Cc: Ian.Campbell@citrix.com, x86@kernel.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, "H. Peter Anvin" List-Id: xen-devel@lists.xenproject.org On Tue, Jul 31, 2012 at 05:41:51PM +0100, Jan Beulich wrote: > >>> On 31.07.12 at 18:15, Konrad Rzeszutek Wilk wrote: > > On Tue, Jul 31, 2012 at 08:49:21AM -0700, H. Peter Anvin wrote: > >> This means you're either abusing the brk allocator to do something > >> it is not meant to do... which may mean you can a failure in *other* > >> code, or you have a bug in your code that you haven't fixed. > > > > Its the latter - and of one of the patches in this patchset fixes that. > > But then you also can't assume that fitting a 2Gb MMIO hole will > suffice; I have a machine here that I can configure to have a > 3Gb hole, so I think you really need to be on the safe side and > allow to cover all the way up to 4Gb with the space you reserve. I have a patch to address that were the P2M leafs are re-used (the ones that either full of 1:1 PFNs or INVALID_P2M_ENTRY). But somehow its hitting a bug.. > > Jan