From: Tim Deegan <tim@xen.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] arm: fix gic_init_secondary_cpu.
Date: Thu, 2 Aug 2012 12:09:06 +0100 [thread overview]
Message-ID: <20120802110906.GD11437@ocelot.phlegethon.org> (raw)
In-Reply-To: <1343839438-3321-1-git-send-email-ian.campbell@citrix.com>
At 16:43 +0000 on 01 Aug (1343839437), Ian Campbell wrote:
> Using spin_lock_irq here is unnecessary (interrupts are not yet enabled) and
> wrong (since they will get unexpectedly renabled by spin_unlock_irq).
>
> We can just use spin_lock/spin_unlock.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
> Now an SMP model gets as far as hanging at dom0 "Calibrating delay loop...".
>
> Tim, didn't you diagnose that a while ago?
I only got as far as showing that dom0 is spinning waiting for jiffies
to increase, but never taking the timer interrupts that would cause that
to happen.
Tim.
next prev parent reply other threads:[~2012-08-02 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 16:43 [PATCH] arm: fix gic_init_secondary_cpu Ian Campbell
2012-08-02 11:09 ` Tim Deegan [this message]
2012-08-03 8:56 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802110906.GD11437@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).