From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] arm: fix gic_init_secondary_cpu.
Date: Thu, 2 Aug 2012 12:09:06 +0100
Message-ID: <20120802110906.GD11437@ocelot.phlegethon.org>
References: <1343839438-3321-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1343839438-3321-1-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

At 16:43 +0000 on 01 Aug (1343839437), Ian Campbell wrote:
> Using spin_lock_irq here is unnecessary (interrupts are not yet enabled) and
> wrong (since they will get unexpectedly renabled by spin_unlock_irq).
> 
> We can just use spin_lock/spin_unlock.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Tim Deegan <tim@xen.org>

> Now an SMP model gets as far as hanging at dom0 "Calibrating delay loop...".
> 
> Tim, didn't you diagnose that a while ago?

I only got as far as showing that dom0 is spinning waiting for jiffies
to increase, but never taking the timer interrupts that would cause that
to happen.

Tim.