From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [xen-unstable test] 13539: regressions - FAIL Date: Fri, 3 Aug 2012 09:39:55 +0100 Message-ID: <20120803083955.GB25286@ocelot.phlegethon.org> References: <1343970755.24794.0.camel@dagon.hellion.org.uk> <1343980112.21372.4.camel@zakaz.uk.xensource.com> <20120803083441.GA25286@ocelot.phlegethon.org> <1343983078.21372.18.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1343983078.21372.18.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "Keir (Xen.org)" , Christoph Egger , "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org At 09:37 +0100 on 03 Aug (1343986678), Ian Campbell wrote: > On Fri, 2012-08-03 at 09:34 +0100, Tim Deegan wrote: > > At 08:48 +0100 on 03 Aug (1343983712), Ian Campbell wrote: > > > nestedhvm: fix nested page fault build error on 32-bit > > > > > > cc1: warnings being treated as errors > > > hvm.c: In function ???hvm_hap_nested_page_fault???: > > > hvm.c:1282: error: passing argument 2 of ???nestedhvm_hap_nested_page_fault??? from incompatible pointer type /local/scratch/ianc/devel/xen-unstable.hg/xen/include/asm/hvm/nestedhvm.h:55: note: expected ???paddr_t *??? but argument is of type ???long unsigned int *??? > > > > > > hvm_hap_nested_page_fault takes an unsigned long gpa and passes &gpa > > > to nestedhvm_hap_nested_page_fault which takes a paddr_t *. Since both > > > of the callers of hvm_hap_nested_page_fault (svm_do_nested_pgfault and > > > ept_handle_violation) actually have the gpa which they pass to > > > hvm_hap_nested_page_fault as a paddr_t I think it makes sense to > > > change the argument to hvm_hap_nested_page_fault. > > > > > > The other user of gpa in hvm_hap_nested_page_fault is a call to > > > p2m_mem_access_check, which currently also takes a paddr_t gpa but I > > > think a paddr_t is appropriate there too. > > > > > > Signed-off-by: Ian Campbell > > > > Acked-by: Tim Deegan > > Is one of you or Jan going to apply or shall I? (I'm doing a tools > commit sweep right now) If you're already applying things, please do apply up this one too. Tim.