From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 03/23] xen/arm: page.h definitions Date: Tue, 7 Aug 2012 14:13:22 -0400 Message-ID: <20120807181322.GG15053@phenom.dumpdata.com> References: <1344263246-28036-3-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1344263246-28036-3-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org Errors-To: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org To: Stefano Stabellini Cc: xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, tim-LM2mM/qkH7s@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: xen-devel@lists.xenproject.org On Mon, Aug 06, 2012 at 03:27:06PM +0100, Stefano Stabellini wrote: > ARM Xen guests always use paging in hardware, like PV on HVM guests in > the X86 world. > > Signed-off-by: Stefano Stabellini Ack.. with one nitpick > +/* XXX: this shouldn't be here */ .. but its here b/c the frontend drivers are using it (its rolled in headers)- even though we won't hit the code path. So for right now just punt with this. > +static inline pte_t *lookup_address(unsigned long address, unsigned int *level) > +{ > + BUG(); > + return NULL; > +} > + > +static inline int m2p_add_override(unsigned long mfn, struct page *page, > + struct gnttab_map_grant_ref *kmap_op) > +{ > + return 0; > +} > + > +static inline int m2p_remove_override(struct page *page, bool clear_pte) > +{ > + return 0; > +} > + > +static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn) > +{ > + BUG(); > + return false; > +} > +#endif /* _ASM_ARM_XEN_PAGE_H */ > -- > 1.7.2.5