From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 18/23] xen: allow privcmd for HVM guests Date: Tue, 7 Aug 2012 14:31:55 -0400 Message-ID: <20120807183155.GU15053@phenom.dumpdata.com> References: <1344263246-28036-18-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1344263246-28036-18-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org Errors-To: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org To: Stefano Stabellini Cc: xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, tim-LM2mM/qkH7s@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: xen-devel@lists.xenproject.org On Mon, Aug 06, 2012 at 03:27:21PM +0100, Stefano Stabellini wrote: > This patch removes the "return -ENOSYS" for auto_translated_physmap > guests from privcmd_mmap, thus it allows ARM guests to issue privcmd > mmap calls. However privcmd mmap calls are still going to fail for HVM > and hybrid guests on x86 because the xen_remap_domain_mfn_range > implementation is currently PV only. Looks good. Ack from me. > > Changes in v2: > > - better commit message; > - return -EINVAL from xen_remap_domain_mfn_range if > auto_translated_physmap. > > Signed-off-by: Stefano Stabellini > --- > arch/x86/xen/mmu.c | 3 +++ > drivers/xen/privcmd.c | 4 ---- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c > index 3a73785..885a223 100644 > --- a/arch/x86/xen/mmu.c > +++ b/arch/x86/xen/mmu.c > @@ -2310,6 +2310,9 @@ int xen_remap_domain_mfn_range(struct vm_area_struct *vma, > unsigned long range; > int err = 0; > > + if (xen_feature(XENFEAT_auto_translated_physmap)) > + return -EINVAL; > + > prot = __pgprot(pgprot_val(prot) | _PAGE_IOMAP); > > BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_RESERVED | VM_IO)) == > diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c > index ccee0f1..85226cb 100644 > --- a/drivers/xen/privcmd.c > +++ b/drivers/xen/privcmd.c > @@ -380,10 +380,6 @@ static struct vm_operations_struct privcmd_vm_ops = { > > static int privcmd_mmap(struct file *file, struct vm_area_struct *vma) > { > - /* Unsupported for auto-translate guests. */ > - if (xen_feature(XENFEAT_auto_translated_physmap)) > - return -ENOSYS; > - > /* DONTCOPY is essential for Xen because copy_page_range doesn't know > * how to recreate these mappings */ > vma->vm_flags |= VM_RESERVED | VM_IO | VM_DONTCOPY | VM_PFNMAP; > -- > 1.7.2.5