xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
Subject: [RFC PATCH 8/8]: PVH: privcmd changes
Date: Wed, 15 Aug 2012 18:07:16 -0700	[thread overview]
Message-ID: <20120815180716.0049bffe@mantra.us.oracle.com> (raw)


---
 drivers/xen/privcmd.c |   68 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 66 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index ccee0f1..0a240ab 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -33,6 +33,7 @@
 #include <xen/features.h>
 #include <xen/page.h>
 #include <xen/xen-ops.h>
+#include <xen/balloon.h>
 
 #include "privcmd.h"
 
@@ -199,6 +200,10 @@ static long privcmd_ioctl_mmap(void __user *udata)
 	if (!xen_initial_domain())
 		return -EPERM;
 
+	/* PVH: TBD/FIXME. For now we only support privcmd_ioctl_mmap_batch */
+	if (xen_pvh_domain())
+		return -ENOSYS;
+
 	if (copy_from_user(&mmapcmd, udata, sizeof(mmapcmd)))
 		return -EFAULT;
 
@@ -251,6 +256,8 @@ struct mmap_batch_state {
 	xen_pfn_t __user *user;
 };
 
+/* PVH dom0: if domU being created is PV, then mfn is mfn(addr on bus). If
+ * it's PVH then mfn is pfn (input to HAP). */
 static int mmap_batch_fn(void *data, void *state)
 {
 	xen_pfn_t *mfnp = data;
@@ -274,6 +281,40 @@ static int mmap_return_errors(void *data, void *state)
 	return put_user(*mfnp, st->user++);
 }
 
+/* Allocate pfns that are then mapped with gmfns from foreign domid. Update
+ * the vma with the page info to use later.
+ * Returns: 0 if success, otherwise -errno
+ */
+static int pvh_privcmd_resv_pfns(struct vm_area_struct *vma, int numpgs)
+{
+	int rc;
+	struct xen_pvh_sav_pfn_info *savp;
+
+	savp = kzalloc(sizeof(struct xen_pvh_sav_pfn_info), GFP_KERNEL);
+	if (savp == NULL)
+		return -ENOMEM;
+
+	savp->sp_paga = kcalloc(numpgs, sizeof(savp->sp_paga[0]), GFP_KERNEL);
+	if (savp->sp_paga == NULL) {
+		kfree(savp);
+		return -ENOMEM;
+	}
+
+	rc = alloc_xenballooned_pages(numpgs, savp->sp_paga, 0);
+	if (rc != 0) {
+		pr_warn("%s Could not alloc %d pfns rc:%d\n", __FUNCTION__,
+			numpgs, rc);
+		kfree(savp->sp_paga);
+		kfree(savp);
+		return -ENOMEM;
+	}
+	savp->sp_num_pgs = numpgs;
+	BUG_ON(vma->vm_private_data);
+	vma->vm_private_data = savp;
+
+	return 0;
+}
+
 static struct vm_operations_struct privcmd_vm_ops;
 
 static long privcmd_ioctl_mmap_batch(void __user *udata)
@@ -315,6 +356,12 @@ static long privcmd_ioctl_mmap_batch(void __user *udata)
 		goto out;
 	}
 
+	if (xen_pvh_domain()) {
+		if ((ret=pvh_privcmd_resv_pfns(vma, m.num))) {
+			up_write(&mm->mmap_sem);
+			goto out;
+		}
+	}
 	state.domain = m.dom;
 	state.vma = vma;
 	state.va = m.addr;
@@ -365,6 +412,19 @@ static long privcmd_ioctl(struct file *file,
 	return ret;
 }
 
+static void privcmd_close(struct vm_area_struct *vma)
+{
+	struct xen_pvh_sav_pfn_info *savp;
+
+	if (!xen_pvh_domain() || ((savp=vma->vm_private_data) == NULL))
+		return;
+
+	while (savp->sp_next_todo--) {
+		xen_pfn_t pfn = page_to_pfn(savp->sp_paga[savp->sp_next_todo]);
+		pvh_rem_xen_p2m(pfn, 1);
+	}
+}
+
 static int privcmd_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 {
 	printk(KERN_DEBUG "privcmd_fault: vma=%p %lx-%lx, pgoff=%lx, uv=%p\n",
@@ -375,13 +435,14 @@ static int privcmd_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 }
 
 static struct vm_operations_struct privcmd_vm_ops = {
+	.close = privcmd_close,
 	.fault = privcmd_fault
 };
 
 static int privcmd_mmap(struct file *file, struct vm_area_struct *vma)
 {
-	/* Unsupported for auto-translate guests. */
-	if (xen_feature(XENFEAT_auto_translated_physmap))
+	/* Unsupported for auto-translate guests unless PVH */
+	if (xen_feature(XENFEAT_auto_translated_physmap) && !xen_pvh_domain())
 		return -ENOSYS;
 
 	/* DONTCOPY is essential for Xen because copy_page_range doesn't know
@@ -395,6 +456,9 @@ static int privcmd_mmap(struct file *file, struct vm_area_struct *vma)
 
 static int privcmd_enforce_singleshot_mapping(struct vm_area_struct *vma)
 {
+	if (xen_pvh_domain())
+		return (vma->vm_private_data == NULL);
+
 	return (xchg(&vma->vm_private_data, (void *)1) == NULL);
 }
 
-- 
1.7.2.3

             reply	other threads:[~2012-08-16  1:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16  1:07 Mukesh Rathor [this message]
2012-08-17 10:01 ` [RFC PATCH 8/8]: PVH: privcmd changes Ian Campbell
2012-09-11 14:10 ` Ian Campbell
2012-09-12  1:32   ` Mukesh Rathor
2012-09-12  7:36     ` Ian Campbell
2012-09-12 18:00       ` Mukesh Rathor
2012-09-13  1:19   ` Mukesh Rathor
2012-09-13 11:37     ` Ian Campbell
2012-09-13 18:27       ` Mukesh Rathor
2012-09-13 19:01         ` Ian Campbell
2012-09-13 19:05         ` Konrad Rzeszutek Wilk
2012-09-14  0:34       ` Mukesh Rathor
2012-09-17 23:50         ` Mukesh Rathor
2012-09-18  7:32           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120815180716.0049bffe@mantra.us.oracle.com \
    --to=mukesh.rathor@oracle.com \
    --cc=Xen-devel@lists.xensource.com \
    --cc=konrad.wilk@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).