From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [[RFC PATCH 2/8]: PVH: changes related to initial boot and irq rewiring Date: Thu, 16 Aug 2012 15:09:35 -0400 Message-ID: <20120816190935.GA3428@phenom.dumpdata.com> References: <20120815180131.24aaa5ce@mantra.us.oracle.com> <20120816140929.GB17687@phenom.dumpdata.com> <20120816120041.15d382ed@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120816120041.15d382ed@mantra.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mukesh Rathor Cc: "Xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Thu, Aug 16, 2012 at 12:00:41PM -0700, Mukesh Rathor wrote: > On Thu, 16 Aug 2012 10:09:29 -0400 > Konrad Rzeszutek Wilk wrote: > > > > +#ifdef CONFIG_X86_32 > > > + xen_raw_printk("ERROR: 32bit PV guest can not run in HVM > > > container\n"); > > > + return; > > > > Perhaps BUG() ? > > BUG() will prob not work because it's way early in boot, which is why > I figured the prev if statement (right before it) has return. It will crash with this: XEN) domain_crash_sync called from entry.S .. some more data. > > thanks, > Mukesh