From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [RFC PATCH 3/8]: PVH: memory manager and paging related changes
Date: Fri, 17 Aug 2012 16:40:19 -0700 [thread overview]
Message-ID: <20120817164019.73600ee1@mantra.us.oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1208161507020.4850@kaball.uk.xensource.com>
On Thu, 16 Aug 2012 15:10:03 +0100
Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
> > void __init xen_init_mmu_ops(void)
> > {
> > + x86_init.paging.pagetable_setup_done =
> > xen_pagetable_setup_done; +
> > + if (xen_pvh_domain()) {
> > + pv_mmu_ops.flush_tlb_others = xen_flush_tlb_others;
> > +
> > + /* set_pte* for PCI devices to map iomem. */
> > + if (xen_initial_domain()) {
> > + pv_mmu_ops.set_pte = xen_dom0pvh_set_pte;
> > + pv_mmu_ops.set_pte_at =
> > xen_dom0pvh_set_pte_at;
> > + }
> > + return;
> > + }
>
> Considering that the implementation of xen_dom0pvh_set_pte is
> native_set_pte, can't we just leave it to the default that is
> native_set_pte?
We can. I had more code in the function that I removed when I mapped
the entire IO space up front. Then, I had lot of debug code there.
I can change it to native now.
next prev parent reply other threads:[~2012-08-17 23:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 1:02 [RFC PATCH 3/8]: PVH: memory manager and paging related changes Mukesh Rathor
2012-08-16 14:10 ` Stefano Stabellini
2012-08-16 14:15 ` Ian Campbell
2012-08-17 23:40 ` Mukesh Rathor [this message]
2012-08-17 9:26 ` Ian Campbell
2012-08-17 23:49 ` Mukesh Rathor
2012-09-14 16:20 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817164019.73600ee1@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Xen-devel@lists.xensource.com \
--cc=konrad.wilk@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).