From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [RFC PATCH 3/8]: PVH: memory manager and paging
 related changes
Date: Fri, 17 Aug 2012 16:40:19 -0700
Message-ID: <20120817164019.73600ee1@mantra.us.oracle.com>
References: <20120815180250.1e068d10@mantra.us.oracle.com>
	<alpine.DEB.2.02.1208161507020.4850@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1208161507020.4850@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 16 Aug 2012 15:10:03 +0100
Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:

> >  void __init xen_init_mmu_ops(void)
> >  {
> > +       x86_init.paging.pagetable_setup_done =
> > xen_pagetable_setup_done; +
> > +       if (xen_pvh_domain()) {
> > +               pv_mmu_ops.flush_tlb_others = xen_flush_tlb_others;
> > +
> > +               /* set_pte* for PCI devices to map iomem. */
> > +               if (xen_initial_domain()) {
> > +                       pv_mmu_ops.set_pte = xen_dom0pvh_set_pte;
> > +                       pv_mmu_ops.set_pte_at =
> > xen_dom0pvh_set_pte_at;
> > +               }
> > +               return;
> > +       }
> 
> Considering that the implementation of xen_dom0pvh_set_pte is
> native_set_pte, can't we just leave it to the default that is
> native_set_pte?

We can. I had more code in the function that I removed when I mapped
the entire IO space up front. Then, I had lot of debug code there. 
I can change it to native now.