Re: [RFC PATCH 7/8]: PVH: grant changes

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Fri, 17 Aug 2012 10:52:30 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> On Thu, 2012-08-16 at 02:06 +0100, Mukesh Rathor wrote:
> > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> > index 0bfc1ef..2430133 100644
> > --- a/drivers/xen/grant-table.c
> > +++ b/drivers/xen/grant-table.c


> > HYPERVISOR_memory_op(XENMEM_add_to_physmap, &xatp); if (rc != 0) {
> >  				printk(KERN_WARNING
> > @@ -1053,7 +1058,7 @@ static void gnttab_request_version(void)
> >  	int rc;
> >  	struct gnttab_set_version gsv;
> >  
> > -	if (xen_hvm_domain())
> > +	if (xen_hvm_domain() || xen_pvh_domain())
> 
> Does something stop pvh using v2?

I had some issue related to grstatus field that was added, so punted it
for now. It's phase II which is a big phase now :) :)... 


> >  
> > -	if (xen_pv_domain())
> > +	/* PVH note: xen will free existing kmalloc'd mfn in
> > +	 * XENMEM_add_to_physmap */
> > +	if (xen_pvh_domain() && !gnttab_shared.addr) {
> > +		gnttab_shared.addr =
> > +			kmalloc(max_nr_gframes * PAGE_SIZE,
> > GFP_KERNEL);
> > +		if ( !gnttab_shared.addr ) {
> > +			printk(KERN_WARNING "%s", kmsg);
> 
> Why this construct instead of just the string literal?
 
To keep line overflow. I dont' like code spanning 80 columns. If you split,
then you can't grep.