From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luiz Capitulino Subject: Re: [RFC 3/8] qapi-types.h doesn't really need to include qemu-common.h Date: Tue, 21 Aug 2012 15:21:48 -0300 Message-ID: <20120821152148.3bcff810@doriath.home> References: <1345563782-11224-1-git-send-email-ehabkost@redhat.com> <1345563782-11224-4-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1345563782-11224-4-git-send-email-ehabkost@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Eduardo Habkost Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, xen-devel@lists.xensource.com, i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com, avi@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com, sw@weilnetz.de, imammedo@redhat.com, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de List-Id: xen-devel@lists.xenproject.org On Tue, 21 Aug 2012 12:42:57 -0300 Eduardo Habkost wrote: > From: Igor Mammedov > > needed to prevent build breakage when CPU becomes a child of DeviceState > > Signed-off-by: Igor Mammedov > --- > scripts/qapi-types.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py > index cf601ae..f34addb 100644 > --- a/scripts/qapi-types.py > +++ b/scripts/qapi-types.py > @@ -263,7 +263,7 @@ fdecl.write(mcgen(''' > #ifndef %(guard)s > #define %(guard)s > > -#include "qemu-common.h" > +#include Case you didn't notice my last review: we should also include here. > > ''', > guard=guardname(h_file)))