Re: [RFC PATCH 5/8]: PVH: smp changes

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Fri, 17 Aug 2012 10:42:11 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> > @@ -339,7 +343,20 @@ cpu_initialize_context(unsigned int cpu,
> > struct task_struct *idle) (unsigned long)xen_hypervisor_callback;
> >  		ctxt->failsafe_callback_eip = 
> >  					(unsigned
> > long)xen_failsafe_callback; -
> > +	} else {
> > +		ctxt->user_regs.ds = __KERNEL_DS;
> > +		ctxt->user_regs.es = 0;
> > +		ctxt->user_regs.gs = 0;
> 
> Not __KERNEL_DS for es too?

64bit, es ignored, right?

> Not sure about gs -- shouldn't that point to some per-cpu segment or
> something? Maybe that happens somewhere else? (in which case a
> comment?)

Gets set later. comment good idea.

> > +
> > +		ctxt->gdt_frames[0] = (unsigned long)gdt;
> > +		ctxt->gdt_ents = (unsigned long)(GDT_SIZE - 1);
> > +
> > +		/* Note: PVH is not supported on x86_32. */
> > +#ifdef __x86_64__
> 
> ITYM CONFIG_X86_64?

Yup.