From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastian Blank <waldi@debian.org>
Subject: Re: [PATCH 2/3] xen/privcmd: report paged-out frames in
 PRIVCMD_MMAPBATCH ioctl
Date: Fri, 24 Aug 2012 20:01:24 +0200
Message-ID: <20120824180124.GA7998@wavehammer.waldi.eu.org>
References: <1345742026-10569-1-git-send-email-david.vrabel@citrix.com>
	<1345742026-10569-3-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1345742026-10569-3-git-send-email-david.vrabel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: Andres Lagar-Cavilla <andres@gridcentric.ca>, xen-devel@lists.xensource.com, Keir Fraser <keir@xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Aug 23, 2012 at 06:13:45PM +0100, David Vrabel wrote:
> +	if (ret < 0) {
> +		if (ret == -ENOENT)
> +			*mfnp |= 0x80000000U;
> +		else
> +			*mfnp |= 0xf0000000U;

Please don't use magic constants.

Bastian

-- 
Respect is a rational process
		-- McCoy, "The Galileo Seven", stardate 2822.3