From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
xen-devel@lists.xensource.com, linaro-dev@lists.linaro.org,
linux-pm@vger.kernel.org, patches@linaro.org,
linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [PATCH] acpi : remove power from acpi_processor_cx structure
Date: Sat, 1 Sep 2012 07:54:58 +0200 [thread overview]
Message-ID: <201209010754.58999.rjw@sisk.pl> (raw)
In-Reply-To: <50410811.70500@linaro.org>
On Friday, August 31, 2012, Daniel Lezcano wrote:
> On 07/24/2012 11:06 PM, Konrad Rzeszutek Wilk wrote:
> > On Tue, Jul 24, 2012 at 11:12:29PM +0200, Daniel Lezcano wrote:
> >> Remove the power field as it is not used.
> >>
> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> >> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Acked.
>
> Hi Rafael,
>
> I did not see this patch going in. Is it possible to merge it ?
I think so. I'll take care of it when I get back from LinuxCon/Plumbers Conf.
(early next week).
Thanks,
Rafael
> >> ---
> >> drivers/acpi/processor_idle.c | 2 --
> >> drivers/xen/xen-acpi-processor.c | 1 -
> >> include/acpi/processor.h | 1 -
> >> 3 files changed, 0 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> >> index e589c19..90582fb 100644
> >> --- a/drivers/acpi/processor_idle.c
> >> +++ b/drivers/acpi/processor_idle.c
> >> @@ -483,8 +483,6 @@ static int acpi_processor_get_power_info_cst(struct acpi_processor *pr)
> >> if (obj->type != ACPI_TYPE_INTEGER)
> >> continue;
> >>
> >> - cx.power = obj->integer.value;
> >> -
> >> current_count++;
> >> memcpy(&(pr->power.states[current_count]), &cx, sizeof(cx));
> >>
> >> diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c
> >> index 7ff2569..7ef9c1d 100644
> >> --- a/drivers/xen/xen-acpi-processor.c
> >> +++ b/drivers/xen/xen-acpi-processor.c
> >> @@ -98,7 +98,6 @@ static int push_cxx_to_hypervisor(struct acpi_processor *_pr)
> >>
> >> dst_cx->type = cx->type;
> >> dst_cx->latency = cx->latency;
> >> - dst_cx->power = cx->power;
> >>
> >> dst_cx->dpcnt = 0;
> >> set_xen_guest_handle(dst_cx->dp, NULL);
> >> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> >> index 64ec644..db427fa 100644
> >> --- a/include/acpi/processor.h
> >> +++ b/include/acpi/processor.h
> >> @@ -59,7 +59,6 @@ struct acpi_processor_cx {
> >> u8 entry_method;
> >> u8 index;
> >> u32 latency;
> >> - u32 power;
> >> u8 bm_sts_skip;
> >> char desc[ACPI_CX_DESC_LEN];
> >> };
> > _______________________________________________
> > linaro-dev mailing list
> > linaro-dev@lists.linaro.org
> > http://lists.linaro.org/mailman/listinfo/linaro-dev
> >
>
>
>
next prev parent reply other threads:[~2012-09-01 5:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 21:12 [PATCH] acpi : remove power from acpi_processor_cx structure Daniel Lezcano
2012-07-24 21:06 ` Konrad Rzeszutek Wilk
2012-08-31 18:53 ` Daniel Lezcano
2012-09-01 5:54 ` Rafael J. Wysocki [this message]
2012-09-05 13:41 ` Rafael J. Wysocki
2012-09-06 7:54 ` Daniel Lezcano
2012-09-06 9:22 ` CONFIG_NO_HZ + CONFIG_CPU_IDLE freeze the system (Was Re: [PATCH] acpi : remove power from acpi_processor_cx structure) Daniel Lezcano
2012-09-06 20:04 ` Rafael J. Wysocki
2012-09-06 20:35 ` Daniel Lezcano
2012-09-06 21:18 ` Rafael J. Wysocki
2012-09-07 14:20 ` Daniel Lezcano
[not found] ` <504A02BD.4000805-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-07 17:22 ` John Stultz
2012-09-07 21:35 ` Daniel Lezcano
2012-09-10 17:14 ` John Stultz
2012-09-10 19:45 ` Daniel Lezcano
2012-09-11 0:18 ` John Stultz
2012-09-11 6:58 ` Daniel Lezcano
[not found] ` <504EE124.3010401-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-11 17:26 ` John Stultz
[not found] ` <504E8372.20904-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-11 21:27 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209010754.58999.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=daniel.lezcano@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=lenb@kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).