From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [[RFC PATCH 2/8]: PVH: changes related to initial boot and irq rewiring
Date: Tue, 4 Sep 2012 16:56:22 -0700 [thread overview]
Message-ID: <20120904165622.73bdf81c@mantra.us.oracle.com> (raw)
In-Reply-To: <1345193780.30865.109.camel@zakaz.uk.xensource.com>
On Fri, 17 Aug 2012 09:56:20 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:
>
> [...]
> > diff --git a/arch/x86/xen/irq.c b/arch/x86/xen/irq.c
> > index 1573376..7c7dfd1 100644
> > --- a/arch/x86/xen/irq.c
> > +++ b/arch/x86/xen/irq.c
> > @@ -100,6 +100,10 @@ PV_CALLEE_SAVE_REGS_THUNK(xen_irq_enable);
> >
> > static void xen_safe_halt(void)
> > {
> > + /* so event channel can be delivered to us, since in HVM
> > container */
> > + if (xen_pvh_domain())
> > + local_irq_enable();
> > +
> > /* Blocking includes an implicit local_irq_enable(). */
>
> So this comment isn't true for a PVH guest? Why not? Should it be?
>
> I'm half wondering if we couldn't use native_safe_halt here, IIRC both
> SVN and VTd handle "sti; hlt" in a sensible way on the hypervisor side
> by calling hvm_hlt
I was able to change it to use native_safe_halt.
prev parent reply other threads:[~2012-09-04 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 1:01 [[RFC PATCH 2/8]: PVH: changes related to initial boot and irq rewiring Mukesh Rathor
2012-08-16 14:05 ` Stefano Stabellini
2012-08-16 18:56 ` Mukesh Rathor
2012-08-16 14:09 ` Konrad Rzeszutek Wilk
2012-08-16 19:00 ` Mukesh Rathor
2012-08-16 19:09 ` Konrad Rzeszutek Wilk
2012-08-16 21:45 ` Mukesh Rathor
2012-08-17 8:56 ` Ian Campbell
2012-08-17 23:37 ` Mukesh Rathor
2012-08-18 8:23 ` Ian Campbell
2012-09-04 23:56 ` Mukesh Rathor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904165622.73bdf81c@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Xen-devel@lists.xensource.com \
--cc=konrad.wilk@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).