From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Andres Lagar-Cavilla <andreslc@gridcentric.ca>,
Andres Lagar-Cavilla <andres.lagarcavilla@gmail.com>,
"andres@lagarcavilla.org" <andres@lagarcavilla.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] Xen backend support for paged out grant targets.
Date: Wed, 5 Sep 2012 12:27:31 -0400 [thread overview]
Message-ID: <20120905162731.GD11949@phenom.dumpdata.com> (raw)
In-Reply-To: <5040E210.2060702@citrix.com>
On Fri, Aug 31, 2012 at 05:10:56PM +0100, David Vrabel wrote:
> On 31/08/12 16:42, Andres Lagar-Cavilla wrote:
> > Actually acted upon your feedback ipso facto:
> >
> > commit d5fab912caa1f0cf6be0a6773f502d3417a207b6
> > Author: Andres Lagar-Cavilla <andres@lagarcavilla.org>
> > Date: Sun Aug 26 09:45:57 2012 -0400
> >
> > Xen backend support for paged out grant targets.
>
> This looks mostly fine expect for the #define instead of inline functions.
>
> > +#define gnttab_map_grant_no_eagain(_gop) \
>
> This name tripped me up previously. As I read this as:
>
> gnttab_map_grant_no_[retries_for]_eagain().
>
> Perhaps gnttab_map_grant_with_retries() ? Or similar?
gnttab_map_grant_retry ?
Besides that, it looks good to me. Ian Campbell needs to Ack so that
David Miller (the network maintainer) can pick it up. Please CC them
both and also LKML.
>
> David
next prev parent reply other threads:[~2012-09-05 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 16:51 [PATCH] Xen backend support for paged out grant targets andres
2012-08-31 14:32 ` David Vrabel
2012-08-31 14:45 ` Andres Lagar-Cavilla
2012-08-31 15:42 ` Andres Lagar-Cavilla
2012-08-31 16:10 ` David Vrabel
2012-09-05 16:27 ` Konrad Rzeszutek Wilk [this message]
2012-09-05 17:21 ` Andres Lagar-Cavilla
2012-09-12 13:20 ` Andres Lagar-Cavilla
2012-09-12 18:30 ` Konrad Rzeszutek Wilk
2012-08-31 16:54 ` Konrad Rzeszutek Wilk
2012-08-31 19:33 ` Andres Lagar-Cavilla
2012-08-31 21:14 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905162731.GD11949@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=andres.lagarcavilla@gmail.com \
--cc=andres@lagarcavilla.org \
--cc=andreslc@gridcentric.ca \
--cc=david.vrabel@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).