From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: creating _libxl_list.h is racy
Date: Thu, 6 Sep 2012 21:06:51 +0200 [thread overview]
Message-ID: <20120906190650.GA3091@aepfle.de> (raw)
In-Reply-To: <1346957589.10570.46.camel@dagon.hellion.org.uk>
On Thu, Sep 06, Ian Campbell wrote:
> On Thu, 2012-09-06 at 17:57 +0100, Olaf Hering wrote:
> > On Thu, Sep 06, Olaf Hering wrote:
> >
> > > On Thu, Sep 06, Ian Campbell wrote:
> > >
> > > > But there is no depends on _libxl_list.h which is in $(AUTOINCS). Could
> > > > fix by adding AUTOINCS here somewhere but is there any reason not to add
> > > >
> > > > libxl.h: $(AUTOINCS)
> > >
> > > There is already a libxl.h: _libxl_types.h, perhaps _libxl_list.h should
> > > be added here as well.
> >
> > And libxl.h includes also libxl_event.h, so it should depend on that
> > file als well I think.
>
> libxl_event.h isn't autogenerated so the usual gcc generated dependency
> stuff can handle that.
Ok, should I resend my patch?
Olaf
prev parent reply other threads:[~2012-09-06 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 16:39 creating _libxl_list.h is racy Olaf Hering
2012-09-06 16:45 ` Ian Campbell
2012-09-06 16:55 ` Olaf Hering
2012-09-06 16:57 ` Olaf Hering
2012-09-06 18:53 ` Ian Campbell
2012-09-06 19:06 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906190650.GA3091@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).