From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] pygrub: always append --args
Date: Fri, 7 Sep 2012 11:14:28 +0200 [thread overview]
Message-ID: <20120907091428.GA12925@aepfle.de> (raw)
In-Reply-To: <1347006747.30018.37.camel@zakaz.uk.xensource.com>
On Fri, Sep 07, Ian Campbell wrote:
> > except IndexError:
> > img = g.cf.images[0]
> >
> > - grubcfg = { "kernel": None, "ramdisk": None, "args": None }
> > + grubcfg = { "kernel": None, "ramdisk": None, "args": "" }
> >
> > grubcfg["kernel"] = img.kernel[1]
> > if img.initrd:
> > grubcfg["ramdisk"] = img.initrd[1]
> > if img.args:
>
> With the above change isn't this always true?
img.args comes from img = g.cf.images[sel]?
Olaf
next prev parent reply other threads:[~2012-09-07 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 15:29 [PATCH] pygrub: always append --args Olaf Hering
2012-09-07 8:32 ` Ian Campbell
2012-09-07 9:14 ` Olaf Hering [this message]
2012-09-07 9:21 ` Ian Campbell
2012-09-25 10:09 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907091428.GA12925@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).