Re: [RFC PATCH 8/8]: PVH: privcmd changes

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Tue, 11 Sep 2012 15:10:23 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> On Thu, 2012-08-16 at 02:07 +0100, Mukesh Rathor wrote:
> > ---
> >  drivers/xen/privcmd.c |   68
> > +	if (rc != 0) {
> > +		pr_warn("%s Could not alloc %d pfns rc:%d\n",
> > __FUNCTION__,
> > +			numpgs, rc);
> > +		kfree(savp->sp_paga);
> > +		kfree(savp);
> > +		return -ENOMEM;
> > +	}
> 
> I've just been building on this patch to make proper mmap foreign
> support on ARM and I was looking for the place which freed this, both
> the pages back to the balloon and then the array itself. There is code
> in privcmd_close which unmaps the P2M, but I can't find the code which
> frees things back to the balloon. Have I missed something?

You are right, I missed the free. Let me revisit it and make some changes.

thanks,
mukesh