Re: [PATCH v4 1/6] xen: improve changes to xen_add_to_physmap

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Fri, 14 Sep 2012 13:59:47 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> 
> On Wed, 2012-08-22 at 12:08 +0100, Stefano Stabellini wrote:
> > This is an incremental patch on top of
> > c0bc926083b5987a3e9944eec2c12ad0580100e2: in order to retain binary
> > compatibility, it is better to introduce foreign_domid as part of a
> > union containing both size and foreign_domid.
> [...]
> > -    domid_t foreign_domid; /* IFF gmfn_foreign */
> > +    unsigned int space;
> >  
> >  #define XENMAPIDX_grant_table_status 0x80000000
> 
> Was this the final consensus on what this interface ought to look
> like?
> 
> Does it work for PVH too (Mukesh CCd)?

Yes it does. Please lmk if the final version asap so I can put in
my patch, and also test it.


> Might we prefer to have a batched version of this call? I don't think
> we can shoehorn the necessary fields into xen_add_to_physmap_t though.
> 
> Do we think libxc will ever want to call a batch version of
> XENMAPSPACE_gmfn_foreign ? If not then we can probably get away using
> multicall batching. If yes then perhaps not -- libxc doesn'tdo
> multicalls.

Not right now. The whole remap api is one page at a time. 


thanks,
Mukesh