From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 08/10] xen/swiotlb: Remove functions not needed anymore. Date: Fri, 14 Sep 2012 13:06:44 -0400 Message-ID: <20120914170644.GC1481@phenom.dumpdata.com> References: <1347306367-28669-1-git-send-email-konrad.wilk@oracle.com> <1347306367-28669-9-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Stefano Stabellini Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Fri, Sep 14, 2012 at 05:06:16PM +0100, Stefano Stabellini wrote: > On Mon, 10 Sep 2012, Konrad Rzeszutek Wilk wrote: > > Sparse warns us off: > > drivers/xen/swiotlb-xen.c:506:1: warning: symbol 'xen_swiotlb_map_sg' was not declared. Should it be static? > > drivers/xen/swiotlb-xen.c:534:1: warning: symbol 'xen_swiotlb_unmap_sg' was not declared. Should it be static? > > > > and it looks like we do not need this function at all. > > A grep seems to find them used in arch/x86/xen/pci-swiotlb-xen.c. > I fail to see where you removed them from pci-swiotlb-xen.c. Is it in > this patch series or another one? I am not seeing them in that file. I think you found the other variant of it: xen_swiotlb_map_sg_attrs > > > > Signed-off-by: Konrad Rzeszutek Wilk > > --- > > drivers/xen/swiotlb-xen.c | 16 ---------------- > > include/xen/swiotlb-xen.h | 9 --------- > > 2 files changed, 0 insertions(+), 25 deletions(-) > > > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > > index f0825cb..6f81994 100644 > > --- a/drivers/xen/swiotlb-xen.c > > +++ b/drivers/xen/swiotlb-xen.c > > @@ -514,14 +514,6 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > > } > > EXPORT_SYMBOL_GPL(xen_swiotlb_map_sg_attrs); > > > > -int > > -xen_swiotlb_map_sg(struct device *hwdev, struct scatterlist *sgl, int nelems, > > - enum dma_data_direction dir) > > -{ > > - return xen_swiotlb_map_sg_attrs(hwdev, sgl, nelems, dir, NULL); > > -} > > -EXPORT_SYMBOL_GPL(xen_swiotlb_map_sg); > > - > > /* > > * Unmap a set of streaming mode DMA translations. Again, cpu read rules > > * concerning calls here are the same as for swiotlb_unmap_page() above. > > @@ -542,14 +534,6 @@ xen_swiotlb_unmap_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > > } > > EXPORT_SYMBOL_GPL(xen_swiotlb_unmap_sg_attrs); > > > > -void > > -xen_swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sgl, int nelems, > > - enum dma_data_direction dir) > > -{ > > - return xen_swiotlb_unmap_sg_attrs(hwdev, sgl, nelems, dir, NULL); > > -} > > -EXPORT_SYMBOL_GPL(xen_swiotlb_unmap_sg); > > - > > /* > > * Make physical memory consistent for a set of streaming mode DMA translations > > * after a transfer. > > diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h > > index f26f9f3..a0db2b7 100644 > > --- a/include/xen/swiotlb-xen.h > > +++ b/include/xen/swiotlb-xen.h > > @@ -23,15 +23,6 @@ extern dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page, > > extern void xen_swiotlb_unmap_page(struct device *hwdev, dma_addr_t dev_addr, > > size_t size, enum dma_data_direction dir, > > struct dma_attrs *attrs); > > -/* > > -extern int > > -xen_swiotlb_map_sg(struct device *hwdev, struct scatterlist *sg, int nents, > > - enum dma_data_direction dir); > > - > > -extern void > > -xen_swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sg, int nents, > > - enum dma_data_direction dir); > > -*/ > > extern int > > xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > > int nelems, enum dma_data_direction dir, > > -- > > 1.7.7.6 > >