From: Bastian Blank <waldi@debian.org>
To: xen-devel@lists.xen.org
Subject: Saving domain in xl does not have proper cleanup
Date: Sun, 16 Sep 2012 16:58:30 +0200 [thread overview]
Message-ID: <20120916145830.GB22987@wavehammer.waldi.eu.org> (raw)
Hi
Saving a domain without enough available space with xl in 4.2-rc5 fails
to cleanup completely. The domain informations remains in Xenstore,
the domain itself seems to remain in a suspended state and there is not
xl process for it anymore.
Reason is the use of the MUST macro in save_domain. It exits the process
prematurely instead of cleaning up the external visible changes.
Also the MUST macro is broken. exit() only takes "values & 0xff", so
this macro may exit the process with 0 if the error value is chosen
unwisely.
Bastian
--
A princess should not be afraid -- not with a brave knight to protect her.
-- McCoy, "Shore Leave", stardate 3025.3
next reply other threads:[~2012-09-16 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 14:58 Bastian Blank [this message]
2012-09-16 15:36 ` Saving domain in xl does not have proper cleanup Bastian Blank
2012-09-25 10:08 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120916145830.GB22987@wavehammer.waldi.eu.org \
--to=waldi@debian.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).